Return Correct Invoke CNI Error #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
force-pushed
the
ignoreUnmarshalErr
branch
from
902ba54 to
21662d3
Compare
tamilmani1989
requested changes
Jul 9, 2019
| } else if len(output) > 0 { | ||
| var cniError cniTypes.Error | ||
| if err = json.Unmarshal(output, &cniError); err == nil && cniError.Code != 0 { | ||
| if unmarshalErr := json.Unmarshal(output, &cniError); unmarshalErr == nil && cniError.Code != 0 { |
Member
There was a problem hiding this comment.
whats the change here? I see err renamed to unmarshalErr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Test
Azure Batch has tested and confirmed that this resolved their problem with unmarshal errors affecting attach network API.