Fix for CNM issue #375
Merged
Fix for CNM issue #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested review from
ashvindeodhar,
jaer-tsun,
ninzavivek and
saiyan86
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 40.01% 40.93% +0.91%
==========================================
Files 25 25
Lines 3546 3518 -28
==========================================
+ Hits 1419 1440 +21
+ Misses 1927 1870 -57
- Partials 200 208 +8
Continue to review full report at Codecov.
|
ninzavivek
suggested changes
Jul 16, 2019
Contributor
ninzavivek
left a comment
ninzavivek
left a comment
There was a problem hiding this comment.
please add a line describing the change.
saiyan86
previously approved these changes
Jul 16, 2019
Member
Author
this is just initializing field with right value..i reverted back to old change |
ninzavivek
approved these changes
Jul 16, 2019
| ep = &endpoint{ | ||
| Id: epInfo.Id, | ||
| IfName: epInfo.IfName, | ||
| IfName: contIfName, // container veth pair name. In cnm, we won't rename this and docker expects veth name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #This PR will fix issue referred in #356, #280
Special notes for your reviewer:
Release note: