CNS: Do not start CNM by default #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
=======================================
Coverage 40.01% 40.01%
=======================================
Files 25 25
Lines 3546 3546
=======================================
Hits 1419 1419
Misses 1927 1927
Partials 200 200Continue to review full report at Codecov.
|
tamilmani1989
requested changes
Jul 24, 2019
Member
There was a problem hiding this comment.
@ashvindeodhar can you change the name of variable to startcnm and flip false/true flag? Otherwise it will be confusing. If they want to start cnm as part of cns, they can specify startcnm in command line.
ninzavivek
previously approved these changes
Jul 24, 2019
Member
Author
|
@tamilmani1989 addressed your review comment. |
tamilmani1989
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNM starts by default when CNS starts. This change prevents CNM
from starting by default. stopcnm commandline option can be used
to start CNM if needed.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: