Skip to content

Conversation

@tamilmani1989
Copy link
Member

@tamilmani1989 tamilmani1989 commented Aug 6, 2019

What this PR does / why we need it:
Enable IP forwarding for snat bridge in multitenancy case to allow outbound connectivity to pass through. This PR does following things:

  1. Enable IP forwarding in Linux VM by setting sysctl variable
  2. Add iptable forward chain rule to allow traffic coming from snatbridge

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #386 into master will increase coverage by 2.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   40.17%   42.59%   +2.41%     
==========================================
  Files          25       26       +1     
  Lines        3547     3773     +226     
==========================================
+ Hits         1425     1607     +182     
+ Misses       1920     1902      -18     
- Partials      202      264      +62
Impacted Files Coverage Δ
network/ovssnat/ovssnat.go 16.81% <0%> (ø)
npm/namespace.go 61.85% <0%> (+3.09%) ⬆️
npm/parse.go 46.8% <0%> (+12.66%) ⬆️
npm/nwpolicy.go 55.88% <0%> (+13.23%) ⬆️
npm/iptm/iptm.go 55.6% <0%> (+14.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cab93...1d0d432. Read the comment docs.

@tamilmani1989 tamilmani1989 changed the title Enable IP forwarding and block ip spoofing in Linux for mulititenancy Enable IP forwarding for Linux mulititenancy Aug 7, 2019
Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tamilmani1989 tamilmani1989 merged commit b027258 into Azure:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants