Skip to content

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Aug 27, 2019

What this PR does / why we need it:
Distro name changed in aks-engine to aks-ubuntu-18.04 :
https://github.com/Azure/aks-engine/blob/master/docs/topics/clusterdefinitions.md#kubernetesconfig

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
E2E Tests

Special notes for your reviewer:

Release note:

NONE

@matmerr matmerr requested a review from tamilmani1989 August 27, 2019 00:34
tamilmani1989
tamilmani1989 previously approved these changes Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #393 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   42.59%   42.59%           
=======================================
  Files          26       26           
  Lines        3773     3773           
=======================================
  Hits         1607     1607           
  Misses       1902     1902           
  Partials      264      264

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b027258...50ef1b9. Read the comment docs.

Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matmerr matmerr merged commit 307ea8f into Azure:master Aug 27, 2019
@matmerr matmerr deleted the aks-test-u18 branch August 27, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants