Skip to content

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Sep 23, 2025

Reason for Change:

The signed iptables monitor image did not contain the iptables blocker binary, unlike the unsigned image. This change builds the iptables blocker and adds it to the signed image.
Check build and layers output with dive: https://dev.azure.com/msazure/One/_build/results?buildId=137930248&view=results
Confirmed this image has the blocker binary while previous signed images do not.

Issue Fixed:

See above

Requirements:

Notes:

Confirm version is correct

@QxBytes QxBytes self-assigned this Sep 23, 2025
@QxBytes QxBytes requested a review from a team as a code owner September 23, 2025 16:59
@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 16:59
@QxBytes QxBytes added fix Fixes something. cilium Related to Cilium. labels Sep 23, 2025
@QxBytes QxBytes requested a review from isaac-dasan September 23, 2025 16:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the azure-block-iptables binary to the signed iptables monitor image. The signed image was missing this binary component that was present in the unsigned version.

  • Adds build configuration and environment variables for azure-block-iptables version tracking
  • Extends the build script to compile the azure-block-iptables binary with BPF dependencies
  • Includes the binary in the Docker image alongside the existing iptables monitor

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.pipelines/run-pipeline.yaml Adds AZURE_BLOCK_IPTABLES_VERSION environment variable to pipeline stages
.pipelines/build/scripts/azure-iptables-monitor.sh Extends script to build azure-block-iptables binary with BPF toolchain setup
.pipelines/build/ob-prepare.steps.yaml Adds version extraction for azure-block-iptables component
.pipelines/build/dockerfiles/azure-iptables-monitor.Dockerfile Copies azure-block-iptables binary into the container image

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@QxBytes QxBytes added ci Infra or tooling. and removed fix Fixes something. labels Sep 25, 2025
@QxBytes QxBytes changed the title fix: add iptables block signed image ci: add iptables block signed image Sep 25, 2025
@QxBytes QxBytes enabled auto-merge September 27, 2025 02:40
@QxBytes
Copy link
Contributor Author

QxBytes commented Sep 27, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes added this pull request to the merge queue Sep 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2025
@QxBytes QxBytes added this pull request to the merge queue Sep 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2025
@QxBytes QxBytes added this pull request to the merge queue Sep 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2025
@QxBytes QxBytes added this pull request to the merge queue Sep 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2025
@QxBytes QxBytes added this pull request to the merge queue Sep 29, 2025
Merged via the queue into master with commit d09fdf0 Sep 29, 2025
12 of 13 checks passed
@QxBytes QxBytes deleted the alew/add-iptables-block-signed-image branch September 29, 2025 19:25
NihaNallappagari pushed a commit to NihaNallappagari/azure-container-networking that referenced this pull request Oct 9, 2025
* add iptables block to signed image

* fix syntax

* mariner version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling. cilium Related to Cilium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants