-
Notifications
You must be signed in to change notification settings - Fork 257
ci: add iptables block signed image #4049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the azure-block-iptables binary to the signed iptables monitor image. The signed image was missing this binary component that was present in the unsigned version.
- Adds build configuration and environment variables for azure-block-iptables version tracking
- Extends the build script to compile the azure-block-iptables binary with BPF dependencies
- Includes the binary in the Docker image alongside the existing iptables monitor
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
.pipelines/run-pipeline.yaml | Adds AZURE_BLOCK_IPTABLES_VERSION environment variable to pipeline stages |
.pipelines/build/scripts/azure-iptables-monitor.sh | Extends script to build azure-block-iptables binary with BPF toolchain setup |
.pipelines/build/ob-prepare.steps.yaml | Adds version extraction for azure-block-iptables component |
.pipelines/build/dockerfiles/azure-iptables-monitor.Dockerfile | Copies azure-block-iptables binary into the container image |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
* add iptables block to signed image * fix syntax * mariner version
Reason for Change:
The signed iptables monitor image did not contain the iptables blocker binary, unlike the unsigned image. This change builds the iptables blocker and adds it to the signed image.
Check build and layers output with dive: https://dev.azure.com/msazure/One/_build/results?buildId=137930248&view=results
Confirmed this image has the blocker binary while previous signed images do not.
Issue Fixed:
See above
Requirements:
Notes:
Confirm version is correct