Optimize call flow to complete loopback adapter creation #408
Conversation
ashvindeodhar
requested review from
chandanAggarwal,
jaer-tsun and
tamilmani1989
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 52.29% 52.29%
=======================================
Files 28 28
Lines 4044 4044
=======================================
Hits 2115 2115
Misses 1654 1654
Partials 275 275Continue to review full report at Codecov.
|
| bytes, err := c.Output() | ||
| loopbackOperationLock.Unlock() | ||
|
|
||
| if err == nil { |
There was a problem hiding this comment.
do you think we can just combine this? a single line?
There was a problem hiding this comment.
Which lines are you suggesting to combine?
| } | ||
|
|
||
| func setWeakHostOnInterface(ipAddress string) error { | ||
| func setWeakHostOnInterface(ipAddress, ncID string) error { |
There was a problem hiding this comment.
is this function even needed now?
There was a problem hiding this comment.
Is there way to asset the lock has been acquired already?
There was a problem hiding this comment.
asset the lock?
Keeping the function separate because it's still a separate functionality
| } | ||
|
|
||
| func setWeakHostOnInterface(ipAddress string) error { | ||
| func setWeakHostOnInterface(ipAddress, ncID string) error { |
There was a problem hiding this comment.
Is there way to asset the lock has been acquired already?
2 participants
Loopback adapter creation operation comprises of two operations - createInterface and setWeakHostOnInterface. These operations take place inside the lock. If there are simultaneous requests, it interleaves these calls causing every loopback adapter creation to absorb the delay due to interleaving. createInterface can take time in seconds (typically 2 to 7 seconds based on the tests) while setWeakHostOnInterface finishes very quickly ( less than a second ). This change calls setWeakHostOnInterface within the same lock if createInterface succeeds. The tests show this improves the loopback adapter creation times for simultaneous requests.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: