Add Host NC communication support in Windows with HnsV2 #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-vm-container-experiment
…w-vm-container-experiment
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 52.66% 52.66%
=======================================
Files 28 28
Lines 4022 4022
=======================================
Hits 2118 2118
Misses 1631 1631
Partials 273 273Continue to review full report at Codecov.
|
tamilmani1989
approved these changes
Oct 18, 2019
Member
tamilmani1989
left a comment
tamilmani1989
left a comment
There was a problem hiding this comment.
added minor comments. lgtm
| // Following code calculates the subnet prefix from localIPConfiguration IP | ||
| // e.g. IP: 169.254.128.7 Prefix length: 17 then resulting subnet prefix: 169.254.128.0/17 | ||
| // subnetPrefix: ffff8000 | ||
| // subnetPrefix.IP: 169.254.128.0 |
Member
Author
There was a problem hiding this comment.
Added the workitem here:
https://msazure.visualstudio.com/One/_workitems/edit/5582928/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for host NC bidirectional communication with windows HnsV2. This is supported in multitenant scenario only. AllowHostToNCCommunication and AllowNCToHostCommunication flags are used to enable Host to NC and NC to host communication respectively.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: