Skip to content

Conversation

@tamilmani1989
Copy link
Member

What this PR does / why we need it:

  1. Add fields for enabling metrics and logs from application
  2. made logging configurable
    Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename enableLogging to debugMode or something

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   52.66%   52.66%           
=======================================
  Files          28       28           
  Lines        4022     4022           
=======================================
  Hits         2118     2118           
  Misses       1631     1631           
  Partials      273      273

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fb35b...5bff193. Read the comment docs.

@tamilmani1989 tamilmani1989 changed the title addressed concerns discussed during brownbag session [Do not merge] addressed concerns discussed during brownbag session Oct 22, 2019
jaer-tsun
jaer-tsun previously approved these changes Oct 23, 2019
Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tamilmani1989 tamilmani1989 changed the title [Do not merge] addressed concerns discussed during brownbag session addressed concerns discussed during brownbag session Oct 23, 2019
@tamilmani1989
Copy link
Member Author

/azp

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or a specific pipeline for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify a pipeline to run.
    • Example: "run" or "run pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@tamilmani1989
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tamilmani1989 tamilmani1989 merged commit ea079b0 into Azure:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants