K8s Version Comparison Fix #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
changed the title
jaer-tsun
force-pushed
the
validateK8sVer
branch
2 times, most recently
from
341a4b4 to
e55c356
Compare
…ns with hotfix / pre-release tag
jaer-tsun
force-pushed
the
validateK8sVer
branch
from
e55c356 to
54cc0e2
Compare
jaer-tsun
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaer-tsun
force-pushed
the
validateK8sVer
branch
from
ec04fcd to
279858a
Compare
jaer-tsun
force-pushed
the
validateK8sVer
branch
from
279858a to
988e984
Compare
ashutoshishere04
pushed a commit
to ashutoshishere04/azure-container-networking
that referenced
this pull request
Jan 23, 2020
* Modifying the way we compare k8s version so that we don't fail versions with hotfix / pre-release tag * cleaning build directory without flag clean parameter type fix optimized changes spacing-2 spacing unwanted comments removed struct name unchanged flag name changed and mas<->fileIpam test function names corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Modifying the way we compare k8s version so that we don't fail versions with hotfix / pre-release tag.
NPM was stuck on loopback crash because API-server was v1.14.8-hotfix.20191113 instead of the expected v1.14.8