Skip to content

Conversation

@ashvindeodhar
Copy link
Member

AzureNetworkContainer.exe is in the same location as azure-cns.exe but
if CNS is invoked from a process which is in a different working directory,
os.stat called in CNS points to the directory of parent process. This change
fixes the logic to point to the correct working directory.

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #440 into master will decrease coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   53.32%   52.66%   -0.67%     
==========================================
  Files          28       28              
  Lines        4032     4022      -10     
==========================================
- Hits         2150     2118      -32     
- Misses       1610     1631      +21     
- Partials      272      273       +1
Impacted Files Coverage Δ
npm/translatePolicy.go 88.01% <0%> (-3.06%) ⬇️
npm/pod.go 64.13% <0%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d2c68...bb684dc. Read the comment docs.

Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline. lgtm

@ashvindeodhar ashvindeodhar merged commit 8d074e9 into Azure:master Nov 14, 2019
@ashvindeodhar ashvindeodhar deleted the fork-fix-acn-exe-location branch November 14, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants