Fix NPM Regression & Remove TelemetryBuffer Sidecar #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
changed the title
Member
|
@jaer-tsun can you create separate PRs for telemetry change and drop entry precedence |
jaer-tsun
changed the title
jaer-tsun
force-pushed
the
dropPrecedence
branch
from
63e6991 to
88e815f
Compare
- Add drop entry at the end of Ingress-From and Egress-To chains when there are non Allow-All* entries
jaer-tsun
force-pushed
the
dropPrecedence
branch
from
88e815f to
157b140
Compare
jaer-tsun
changed the title
matmerr
approved these changes
Dec 5, 2019
ashutoshishere04
pushed a commit
to ashutoshishere04/azure-container-networking
that referenced
this pull request
Jan 23, 2020
* give precedence to drop rules (over allow) * - Moving kube-system-chain above target-sets-chain - Add drop entry at the end of Ingress-From and Egress-To chains when there are non Allow-All* entries * write logs to stdout (and log file) so that we can see logs via kubectl * removing kube-system chain and fixing tests * removing telemetry buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: