Prevent Namespace Race #461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
changed the title
jaer-tsun
force-pushed
the
npmRebootNamespaceRace
branch
from
7ce6d32 to
8752755
Compare
jaer-tsun
force-pushed
the
npmRebootNamespaceRace
branch
from
ca08403 to
8752755
Compare
jaer-tsun
changed the title
…where entries don't get added after failing to append non-existing namespace to all-namespaces.
jaer-tsun
force-pushed
the
npmRebootNamespaceRace
branch
from
8752755 to
63dd9d5
Compare
matmerr
previously approved these changes
Dec 18, 2019
jaer-tsun
force-pushed
the
npmRebootNamespaceRace
branch
from
f2e306d to
82784c2
Compare
saiyan86
suggested changes
Dec 19, 2019
| return nil | ||
| } | ||
|
|
||
| // AddNamespaceWithLock acquires NetworkPolicyManager lock before adding namespace to ipset |
Contributor
There was a problem hiding this comment.
I think a cleaner way to do this is to unlock & lock in the caller instead of having this function.
Member
There was a problem hiding this comment.
AddNamespace used to take a bool to determine that, but having every signature with a bool seemed a bit like an antipattern, but it can be changed back
Contributor
Author
There was a problem hiding this comment.
That was the pattern I had it in before. And I don't feel strongly about either to change it back and forth
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding namespace to npMgr if it doesn't exist. This fixes reboot bug where entries don't get added after failing to append non-existing namespace to all-namespaces.
When NPM reboots, namespace details do not always sync before policies and pods do. In those cases the namespace will need to be added before we proceed with add/update pod/networkpolicy workflow.