Allow External for Empty Ingress/Egress Rules #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss rules only contain {}
matmerr
approved these changes
Jan 2, 2020
ashutoshishere04
pushed a commit
to ashutoshishere04/azure-container-networking
that referenced
this pull request
Jan 23, 2020
…ss rules only contain {} (Azure#466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
NPM was not treating {} rules as external so the rules get routed to all-namespaces instead.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fixes* #465
*Partially fixes via allow external but ordering needs to be fixed
i.e.
Behaviour depends in the order these policies applied.
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
name: dns
namespace: test
spec:
podSelector: {}
egress:
- to:
- namespaceSelector: {}
ports:
- protocol: UDP
port: 53
kind: NetworkPolicy
apiVersion: networking.k8s.io/v1
metadata:
name: allow-test-egress
namespace: test
spec:
podSelector:
matchLabels:
app: test
egress:
- {}