Add build and publish image capabilities for cns #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested changes
Jan 6, 2020
Makefile
Outdated
| docker push $(AZURE_VNET_TELEMETRY_IMAGE):$(VERSION) | ||
|
|
||
| # Build the Azure CNS image. | ||
| .PHONY: azure-npm-image |
Member
There was a problem hiding this comment.
is this azure-cns-image or npm?
cns/Dockerfile
Outdated
| RUN apt-get update | ||
|
|
||
| # Install plugin | ||
| COPY $CNS_BUILD_DIR/azure-cns /usr/bin |
Member
There was a problem hiding this comment.
can we do it in another location instead of /usr/bin because im adding config file and it should be in same directory as that of azure-cns. Can we copy this to /usr/local dir?
also we have to copy gz file and extract that. If tomorrow we have more than 1 file then we have to edit this docker file everytime
jaer-tsun
force-pushed
the
buildCnsImage
branch
2 times, most recently
from
c9c2b66 to
8c95d6b
Compare
jaer-tsun
force-pushed
the
buildCnsImage
branch
from
8c95d6b to
385442d
Compare
tamilmani1989
approved these changes
Jan 6, 2020
Member
tamilmani1989
left a comment
tamilmani1989
left a comment
There was a problem hiding this comment.
left a minor comment. lgtm
| docker save $(AZURE_CNS_IMAGE):$(VERSION) | gzip -c > $(CNS_BUILD_DIR)/$(CNS_IMAGE_ARCHIVE_NAME) | ||
| endif | ||
|
|
||
| # Publish the Azure NPM image to a Docker registry |
ashutoshishere04
pushed a commit
to ashutoshishere04/azure-container-networking
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is just for testing purposes; (runners)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: