Skip to content

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Jan 13, 2020

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #474 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   52.74%   52.67%   -0.08%     
==========================================
  Files          28       28              
  Lines        4224     4224              
==========================================
- Hits         2228     2225       -3     
- Misses       1724     1726       +2     
- Partials      272      273       +1
Impacted Files Coverage Δ
telemetry/telemetrybuffer.go 39.25% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df9111...3888ba6. Read the comment docs.

jaer-tsun
jaer-tsun previously approved these changes Jan 13, 2020
Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@matmerr
Copy link
Member Author

matmerr commented Jan 14, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matmerr
Copy link
Member Author

matmerr commented Jan 14, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

"agentPoolProfiles": [
{
"name": "agentpool1",
"count": 3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come linux 1804 has 3 instead of 2 nodes?

Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jaer-tsun jaer-tsun merged commit a59a9aa into Azure:master Jan 14, 2020
ashutoshishere04 pushed a commit to ashutoshishere04/azure-container-networking that referenced this pull request Jan 23, 2020
* update e2e to reuse pipeline artifacts

* install ginkgo

* update e2e config for apiserver

* add clean up step

* aks-engine version

* aks-engine version

* aks-engine version

* aks-engine version

* aks-engine version

* aks-engine version

* aks-engine version

* aks-engine version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants