Skip to content

Fix for setting default config values #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Fix for setting default config values #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cns/configuration/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func ReadConfig() (CNSConfig, error) {
}

// set telmetry setting defaults
func setTelemetrySettingDefaults(telemetrySettings TelemetrySettings) {
func setTelemetrySettingDefaults(telemetrySettings *TelemetrySettings) {
if telemetrySettings.RefreshIntervalInSecs == 0 {
// set the default refresh interval of metadata thread to 15 seconds
telemetrySettings.RefreshIntervalInSecs = 15
Expand All @@ -93,5 +93,5 @@ func setTelemetrySettingDefaults(telemetrySettings TelemetrySettings) {

// Set Default values of CNS config if not specified
func SetCNSConfigDefaults(config *CNSConfig) {
setTelemetrySettingDefaults(config.TelemetrySettings)
setTelemetrySettingDefaults(&config.TelemetrySettings)
}
2 changes: 1 addition & 1 deletion cns/service/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ func main() {
logger.Errorf("[Azure CNS] Error reading cns config: %v", err)
}

logger.Printf("[Azure CNS] Read config :%+v", cnsconfig)
configuration.SetCNSConfigDefaults(&cnsconfig)
logger.Printf("[Azure CNS] Read config :%+v", cnsconfig)

disableTelemetry := cnsconfig.TelemetrySettings.DisableAll

Expand Down