NPM Version Validation #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…91113 instead of 14+
matmerr
previously approved these changes
Feb 6, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
You should add the test I have in this pr - #497 |
Contributor
Author
|
thanks @jchauncey , I've added it but in a different order, since second version for us will always be 1.11 |
robbiezhang
reviewed
Feb 6, 2020
npm/util/util.go
Outdated
| return -2 | ||
| } | ||
| v2, err := semver.NewVersion(secondVer.Major+secondVer.Minor) | ||
| v2, err := semver.NewVersion(secondVer.Major+"."+secondVer.Minor) |
There was a problem hiding this comment.
as a utility function, I think you should not assume the caller always give a right format in the secondVer.
matmerr
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The value of minor was incorrectly assumed to be e.g. 14.8-hotfix.20191113 instead of 14+
Fixes #494