IPv6 Node IPAM #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tamilmani1989 merged 19 commits into Azure:master from matmerr:cni-dualstack-ipam

Apr 2, 2020

Member

matmerr commented Mar 19, 2020

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Ubuntu and others added 5 commits

March 16, 2020 21:49


          switch to go mod

93cc531


          pull node spec from apiserver

6b61759


          carve v6 addresses

0838a00


          address pool

75b4937


          update go mod vendor

25dd612

matmerr commented

View reviewed changes

cni/ipam/ipam_test.go Outdated Show resolved Hide resolved

matmerr commented

View reviewed changes

cni/ipam/ipam_test.go Outdated Show resolved Hide resolved

matmerr commented

View reviewed changes

cnm/ipam/ipam_test.go Outdated Show resolved Hide resolved

matmerr commented

View reviewed changes

ipam/fileIpam.go Outdated Show resolved Hide resolved

matmerr commented

View reviewed changes

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

matmerr commented

View reviewed changes

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

matmerr added 4 commits

March 27, 2020 21:52


          build image

f1ccd9b


          build image

8f8ce9e


          build image

f741d78


          separate go mod for npm

d7e584a

tamilmani1989 requested changes

View reviewed changes

cni/ipam/ipam_test.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

matmerr added 3 commits

March 30, 2020 22:59


          add manager ipv6 ipam test

beb7df7


          added comments and addressed feedback

f1fbb3b


          address comments

99faf0e

matmerr force-pushed the cni-dualstack-ipam branch from 06fd56a to 99faf0e Compare

March 31, 2020 00:13

tamilmani1989 requested changes

View reviewed changes

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam_test.go Show resolved Hide resolved

ipam/manager_ipv6Ipam_test.go Show resolved Hide resolved

ipam/manager_ipv6Ipam_test.go Outdated Show resolved Hide resolved

ipam/manager_ipv6Ipam_test.go Show resolved Hide resolved

tamilmani1989 added the do-not-merge label


          address comments

fbb90d3

tamilmani1989 requested changes

View reviewed changes

common/config.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved

ipam/ipv6Ipam.go Show resolved Hide resolved


          address comments

fb11ae4

matmerr force-pushed the cni-dualstack-ipam branch from 56e57da to 89341fa Compare

April 1, 2020 18:18


          check if loaded

e2af29b

matmerr force-pushed the cni-dualstack-ipam branch from 89341fa to e2af29b Compare

April 1, 2020 18:22

tamilmani1989 requested changes

View reviewed changes

Member

tamilmani1989 left a comment

minor comments

.pipelines/pipeline.yaml Show resolved Hide resolved

common/config.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/ipv6Ipam.go Outdated Show resolved Hide resolved

ipam/manager.go Outdated Show resolved Hide resolved


          address comments

82bec8b

matmerr force-pushed the cni-dualstack-ipam branch from 42dbf03 to 82bec8b Compare

April 1, 2020 21:00


          update pipeline

f95756e

matmerr force-pushed the cni-dualstack-ipam branch 6 times, most recently from 51860f4 to 424be26 Compare

April 1, 2020 23:21


          update pipeline

baa7132

matmerr force-pushed the cni-dualstack-ipam branch 2 times, most recently from bb1246c to a834c83 Compare

April 1, 2020 23:41


          update test message

63827ca

matmerr force-pushed the cni-dualstack-ipam branch from a834c83 to 63827ca Compare

April 1, 2020 23:53

Member Author

matmerr commented Apr 2, 2020

/azp run

azure-pipelines bot commented Apr 2, 2020

Azure Pipelines successfully started running 1 pipeline(s).

matmerr requested a review from tamilmani1989

April 2, 2020 04:15

Member Author

matmerr commented Apr 2, 2020

/azp run

cleanup job passed but not reflected here in azp

azure-pipelines bot commented Apr 2, 2020

Command 'run cleanup' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

Member Author

matmerr commented Apr 2, 2020

/azp run

azure-pipelines bot commented Apr 2, 2020

Azure Pipelines successfully started running 1 pipeline(s).

matmerr removed the do-not-merge label

matmerr changed the title ~~Save Node Spec CNI Dualstack [do-not-merge]~~ IPv6 Node IPAM

tamilmani1989 approved these changes

View reviewed changes

Member

tamilmani1989 left a comment

lgtm

tamilmani1989 merged commit d2ba9bb into Azure:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet