Skip to content

Conversation

@pjohnst5
Copy link
Contributor

What this PR does / why we need it:
This PR adds telemetry capabilities to network monitoring of Eb rules.
It reports discrepancies to telemetry pipeline which can be viewed in jarvis.

Testing
To see the test logs go to this jarvis link

Which issue this PR fixes
Adaptation of this branch

@pjohnst5 pjohnst5 requested a review from tamilmani1989 March 20, 2020 22:42
@matmerr
Copy link
Member

matmerr commented Mar 24, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pjohnst5
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pjohnst5 pjohnst5 requested a review from tamilmani1989 March 25, 2020 19:01
@pjohnst5
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matmerr
Copy link
Member

matmerr commented Mar 26, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pjohnst5 pjohnst5 requested a review from tamilmani1989 March 27, 2020 22:27
Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matmerr
Copy link
Member

matmerr commented Mar 27, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tamilmani1989 tamilmani1989 merged commit 47f6d8f into Azure:master Apr 1, 2020
@pjohnst5 pjohnst5 deleted the networkmonitor_telemetry branch April 30, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants