Skip to content

Fix NPM Bugs #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2020
Merged

Fix NPM Bugs #542

merged 4 commits into from
Apr 11, 2020

Conversation

@jaer-tsun
Copy link
Contributor

@jaer-tsun jaer-tsun commented Apr 7, 2020 •
edited
Loading

What this PR does / why we need it:

  • Removing old npm chains (past baking period) which were causing errors on uninit
  • Add merged policies to processed network policy map
  • Add/delete raw policies to raw network policy map
  • Check if network policy has changed before updating

@jaer-tsun jaer-tsun requested a review from matmerr April 7, 2020 19:02
matmerr
matmerr previously approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@matmerr matmerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaer-tsun jaer-tsun requested a review from matmerr April 10, 2020 17:35
@jaer-tsun jaer-tsun changed the title Remove Old NPM Chains Fix NPM Bugs Apr 10, 2020
@jaer-tsun jaer-tsun merged commit e98b789 into Azure:master Apr 11, 2020
@jaer-tsun jaer-tsun deleted the clearNPMChains branch April 11, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matmerr matmerr matmerr approved these changes

@csfmomo csfmomo csfmomo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaer-tsun @matmerr @csfmomo