Skip to content

Revising add and update network policy logic in npm #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2020
Merged

Revising add and update network policy logic in npm #544

merged 1 commit into from
Apr 13, 2020

Conversation

@jaer-tsun
Copy link
Contributor

@jaer-tsun jaer-tsun commented Apr 13, 2020

What this PR does / why we need it:
Revising add and update network policy logic in npm

  • removing redundant delete from update network policy func
  • use processed and raw network policy maps accordingly

@jaer-tsun jaer-tsun requested a review from matmerr April 13, 2020 16:01
@jaer-tsun jaer-tsun merged commit 5bcce3b into Azure:master Apr 13, 2020
@jaer-tsun jaer-tsun deleted the fixNpmLogic branch April 13, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csfmomo csfmomo csfmomo approved these changes

@matmerr matmerr Awaiting requested review from matmerr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaer-tsun @csfmomo