Skip to content

Check Processed NP Map & Add Update Pod Conditions #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2020
Merged

Check Processed NP Map & Add Update Pod Conditions #546

merged 2 commits into from
Apr 14, 2020

Conversation

@jaer-tsun
Copy link
Contributor

@jaer-tsun jaer-tsun commented Apr 14, 2020

What this PR does / why we need it:

  • check both processed and raw network policy maps when updating
  • when pods get updated, only add the entries back if pod is not in completed or failed state since we're assuming that they will release their IPs

Which issue this PR fixes:
fixes #428

@jaer-tsun jaer-tsun requested review from csfmomo and matmerr April 14, 2020 16:35
csfmomo
csfmomo reviewed Apr 14, 2020
View reviewed changes
@jaer-tsun jaer-tsun merged commit 8162a2b into Azure:master Apr 14, 2020
@jaer-tsun jaer-tsun deleted the checkRawAndProcessed branch April 14, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csfmomo csfmomo csfmomo approved these changes

@matmerr matmerr Awaiting requested review from matmerr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NPM does not remove succeeded pod ips from firewall ipsets

2 participants

@jaer-tsun @csfmomo