Cns yaml #549
Merged
Cns yaml #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king into cns-yaml
…as killing pod automatically on aks cluster
Comment on lines
+23
to
+24
| nodeSelector: | ||
| beta.kubernetes.io/os: linux |
Collaborator
There was a problem hiding this comment.
We'll want to support Windows hosts too, but I imagine a few things will change (like the hostpath file mounts). I think we can cover this case in Helm but let's discuss if we want to try supporting both linux and windows hosts in this manifest file, or if we should go with an alternative like Helm or separate manifests
Comment on lines
+47
to
+50
| - name: log | ||
| hostPath: | ||
| path: /var/log | ||
| type: Directory |
Collaborator
There was a problem hiding this comment.
If we log to stdout instead of writing to a file mounted inside the Pod, we could capture the logs with kube-apiserver, which should help with ops
matmerr
approved these changes
Apr 29, 2020
Member
matmerr
left a comment
matmerr
left a comment
There was a problem hiding this comment.
We're going to need to add an annotation to not schedule on virtualkubelet nodes, but that can be solved later. Aside from @thatmattlong's comments lgtm 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The beginnings of the CNS yaml which will deploy a CNS instance on every AKS worker node for AKS swift.