Named Ports Support #553
Merged
Named Ports Support #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
force-pushed
the
namedPortSupport
branch
from
967292a to
05e33b7
Compare
csfmomo
reviewed
Apr 30, 2020
csfmomo
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding support for named ports in NPM
Which issue this PR fixes:
fixes #550
Notes for reviewer
ipset ip+port hash solution
~$ sudo ipset list azure-npm-671120875
Name: azure-npm-671120875
Type: hash:ip,port
Revision: 5
Header: family inet hashsize 1024 maxelem 65536
Size in memory: 152
References: 1
Number of entries: 1
Members:
10.240.0.21,tcp:80
~$ sudo ipset list azure-npm-420423296
Name: azure-npm-420423296
Type: hash:net
Revision: 6
Header: family inet hashsize 1024 maxelem 65536
Size in memory: 472
References: 4
Number of entries: 2
Members:
10.240.0.21
10.240.0.66
match-set azure-npm-420423296 dst match-set azure-npm-1519775445 dst match-set azure-npm-671120875 dst,dst /* ALLOW-ALL-TCP-PORT-serve-80-TO-app:server-IN-ns-e2e-bqhboou21s78hj9mnud0 */