Skip to content

Conversation

@tamilmani1989
Copy link
Member

What this PR does / why we need it:
This PR adds dual stack support for AKS-engine windows k8s clusters. It uses HNS api to configure both v4 and v6 addresses for containers.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@tamilmani1989
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tamilmani1989
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tamilmani1989
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@aegal aegal self-requested a review May 7, 2020 07:20
aegal
aegal previously approved these changes May 7, 2020
Copy link
Contributor

@aegal aegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

matmerr
matmerr previously approved these changes May 7, 2020
Copy link
Member

@matmerr matmerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tamilmani1989 tamilmani1989 dismissed stale reviews from matmerr and aegal via 094d49a May 7, 2020 18:28
@tamilmani1989 tamilmani1989 merged commit aed0d71 into Azure:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants