Prometheus metrics #590
Merged
Prometheus metrics #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
June 16, 2020 15:59
…metheus in unit testing
…rom metric to metric name
…this new count value are done by passing the metric itself as a param instead of a string
…rror messages into a function
… code, and updated calls to use new form for getting metric values
…and passing in the wrong param type for testing
…ld random metric flux testing function over from ipsm_test
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 37.30% 37.44% +0.14%
==========================================
Files 47 47
Lines 5203 5215 +12
==========================================
+ Hits 1941 1953 +12
Misses 3000 3000
Partials 262 262 |
added 10 commits
June 30, 2020 11:29
…ing the use of an http server
…ing in a wiki page
Contributor
Author
|
Noting here that the PR passed the local environment scale test (TH test). No errors and approximately the same memory usage in azure-npm pod (14 MiB without Prometheus and 18 MiB with Prometheus). |
Contributor
Author
|
Letting @vishiy view the PR |
added 13 commits
July 10, 2020 16:00
…gistering to metric creation functions
…er-based labeling now
…AddToSet, DeleteFromSet, DeleteSet
… Also log the start of http server
…ctions are only used in testing)
…y). Added logging for metric registration/creation, and explicit public function to initialize metrics so that we can finish log config first
neaggarwMS
requested changes
Jul 14, 2020
added 2 commits
July 14, 2020 16:34
neaggarwMS
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds base Prometheus functionality for measuring and emitting custom metrics (time series) in NPM. There are 6 metrics included currently, and others can be added easily. The current metrics are:
Metrics are useful for troubleshooting network issues/configuration and are important to monitor (e.g. number of policies should remain low enough).