Add logic to deal with 0.0.0.0/0 which ipset not support. #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 38.05% 39.86% +1.81%
==========================================
Files 41 42 +1
Lines 4904 4585 -319
==========================================
- Hits 1866 1828 -38
+ Misses 2783 2502 -281
Partials 255 255 |
Member
|
Can we add a test to validate this scenario? |
Contributor
Author
Let me figure out a unit test. |
Member
|
Interesting solution, approved |
matmerr
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: repair 0.0.0.0/0 cidr which ipset not support
Reason for Change:
Ipset doesn't support 0.0.0.0/0 cidr. A general approach is convert it to 1.0.0.0/1 and 128.0.0.0/1