Skip to content

Conversation

@csfmomo
Copy link
Contributor

@csfmomo csfmomo commented Jul 14, 2020

fix: update NPM logs to use Logf statements instead of Printf as those are less CPU intensive.

Reason for Change:
We have merged a change which use Logf to replace Printf, this one is a followup for the rest of Printf introduced by other merging PR.

@csfmomo csfmomo requested a review from neaggarwMS July 14, 2020 06:06
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #610 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
- Coverage   37.67%   37.30%   -0.37%     
==========================================
  Files          47       47              
  Lines        5203     5203              
==========================================
- Hits         1960     1941      -19     
- Misses       2976     3000      +24     
+ Partials      267      262       -5     

@csfmomo csfmomo merged commit b92d8c6 into master Jul 14, 2020
@csfmomo csfmomo deleted the log branch August 20, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants