Implement CreateOrUpdateNetworkContainerInternal API. #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 42.23% 42.49% +0.26%
==========================================
Files 72 72
Lines 9985 9993 +8
==========================================
+ Hits 4217 4247 +30
+ Misses 5316 5276 -40
- Partials 452 470 +18 |
neaggarwMS
changed the title
neaggarwMS
commented
Jul 16, 2020
neaggarwMS
force-pushed
the
cns_addCreateNCAPIForSecondaryCA
branch
from
5b19439 to
f4ebf1c
Compare
neaggarwMS
force-pushed
the
cns_addCreateNCAPIForSecondaryCA
branch
from
ccbafc8 to
0f99ae6
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neaggarwMS
force-pushed
the
cns_addCreateNCAPIForSecondaryCA
branch
from
710a137 to
d3f0ce9
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramiro-gamarra
previously approved these changes
Jul 22, 2020
matmerr
reviewed
Jul 22, 2020
| fmt.Printf("Failed to create CNS object %v\n", err) | ||
| os.Exit(1) | ||
| } | ||
| svc = service.(*HTTPRestService) |
Member
There was a problem hiding this comment.
new svc object is being created on line 110
matmerr
previously approved these changes
Jul 22, 2020
pjohnst5
reviewed
Jul 22, 2020
| // nc := cns.CreateNetworkContainerRequest{ | ||
| // SecondaryIPConfigs: ipconfigs, | ||
| // } | ||
| func addTestStateToRestServer(t *testing.T, secondaryIps []string) { |
Contributor
There was a problem hiding this comment.
nit: Can you declare vars at the beginning of the function in one block like this?
var (
ipConfig cns.IPConfiguration
ipSubnet cns.IPSubnet
...
)
I picked this up from Mat's code and I think it makes for cleaner functions
matmerr
previously approved these changes
Jul 22, 2020
matmerr
previously approved these changes
Jul 23, 2020
pjohnst5
reviewed
Jul 23, 2020
neaggarwMS
force-pushed
the
cns_addCreateNCAPIForSecondaryCA
branch
from
67264cf to
2b8ec6f
Compare
matmerr
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation for CreateOrUpdateNetworkContainerInternal. This will be called by the CNS requestController and it will handle SecondaryIpConfigs update which will add state for new Secondary ips and delete the state for any delta.