Skip to content

Conversation

@tamilmani1989
Copy link
Member

Reason for Change:

Incase if user disables ipv6 kernel setting, then accept_ra file would not exist and sysctl cmd would fail. This PR addresses that scenario

Issue Fixed:

Requirements:

Notes:

@tamilmani1989 tamilmani1989 requested a review from pjohnst5 July 17, 2020 01:28
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #620 into master will increase coverage by 1.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   37.44%   39.29%   +1.84%     
==========================================
  Files          47       43       -4     
  Lines        5215     4779     -436     
==========================================
- Hits         1953     1878      -75     
+ Misses       3000     2643     -357     
+ Partials      262      258       -4     

Copy link
Contributor

@pjohnst5 pjohnst5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andyliuliming
Copy link
Member

this is a great change,
one of our customer are pending on this issue, they tried to disable the ipv6.
and then the azure cni can not work.

@tamilmani1989 could you please merge this and build a new image? thanks in advance.

@tamilmani1989 tamilmani1989 merged commit a42d5ac into Azure:master Jul 22, 2020
neaggarwMS pushed a commit to neaggarwMS/azure-container-networking that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants