CNS yaml update to reflect aks rp helm chart #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 41.95% 41.95%
=======================================
Files 71 71
Lines 10229 10229
=======================================
Hits 4292 4292
Misses 5462 5462
Partials 475 475 |
thatmattlong
reviewed
Aug 7, 2020
thatmattlong
reviewed
Aug 7, 2020
thatmattlong
reviewed
Aug 7, 2020
thatmattlong
reviewed
Aug 7, 2020
thatmattlong
requested changes
Aug 7, 2020
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
A few nits that I'd be fine without changing, but requesting changes on the nodeAffinity
thatmattlong
approved these changes
Aug 7, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This is just a dummy fix to update the example cns yaml we have in our repro which mirrors the aks rp.
The yaml doesn't actually do anything other than stand as a reference.