-
Notifications
You must be signed in to change notification settings - Fork 260
ipam pool leak fix #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipam pool leak fix #640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
==========================================
+ Coverage 42.00% 42.09% +0.08%
==========================================
Files 71 72 +1
Lines 10229 10362 +133
==========================================
+ Hits 4297 4362 +65
- Misses 5459 5531 +72
+ Partials 473 469 -4 |
tamilmani1989
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt see in releaseaddress id is reset to empty? how is it handled?
Discussed offline, it is already handled in the releaseaddress |
tamilmani1989
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Dismissing this since you are on vacation, discussed offline, addressed all comments
|
Hi, see the change for "ipam pool leak fix" has been merged for CNI issues. Ed |
Reason for Change:
This is to address the potential for IPAM to leak IP's and have the pool be stuck in a 'in use ' state.
Issue Fixed:
#633
This also reintroduces some tests that were last in previous commits.
Requirements:
Notes: