Skip to content

Conversation

@csfmomo
Copy link
Contributor

@csfmomo csfmomo commented Aug 7, 2020

test: kernel status checking in unit test for TestDeleteFromList.

Reason for Change:
Previous unit test only check whether error happens when calling DeleteFromList. Add logic to check whether the kernel status match what we expect.
If it works properly, then more kernel status checking will be added in unit test.

  • [X ] adds unit tests

@csfmomo csfmomo requested a review from matmerr August 7, 2020 06:37
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   41.97%   41.97%           
=======================================
  Files          71       71           
  Lines       10232    10232           
=======================================
  Hits         4295     4295           
  Misses       5462     5462           
  Partials      475      475           

Copy link
Member

@matmerr matmerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csfmomo csfmomo merged commit e3659a7 into Azure:master Aug 7, 2020
@csfmomo csfmomo deleted the flakyUnitUpdated branch August 7, 2020 22:02
neaggarwMS pushed a commit to neaggarwMS/azure-container-networking that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants