Cns change cni interfacefor secondary ips #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 41.97% 42.02% +0.04%
==========================================
Files 71 71
Lines 10232 10270 +38
==========================================
+ Hits 4295 4316 +21
- Misses 5463 5477 +14
- Partials 474 477 +3 |
matmerr
reviewed
Aug 11, 2020
matmerr
previously approved these changes
Aug 11, 2020
matmerr
approved these changes
Aug 11, 2020
neaggarwMS
added a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* Fix to pass DnsServer and GatewayIp along with secondaryIpConfig * Validate dnsServer and gatewayIp * Incorporate feedback * fixed build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CNS/CNI contract to also pass GatewayIP and DnsServers for SecondaryIpConfigs.