fix: pass podinfo to CNS delete #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
- Coverage 42.08% 42.03% -0.06%
==========================================
Files 71 71
Lines 10271 10271
==========================================
- Hits 4323 4317 -6
- Misses 5473 5476 +3
- Partials 475 478 +3 |
cns/restserver/util.go
Outdated
| } | ||
|
|
||
| func (service *HTTPRestService) validateIpConfigRequest(ipConfigRequest cns.GetIPConfigRequest) (int, string) { | ||
| func (service *HTTPRestService) validateIpConfigRequest(ipConfigRequest cns.GetIPConfigRequest) (*cns.KubernetesPodInfo, int, string) { |
Collaborator
There was a problem hiding this comment.
I think it would be safer to return a cns.KubernetesPodInfo instead of a pointer. Unless I'm missing something here I don't see the value in using a pointer since we return a pointer to an empty struct instead of nil on error, anyway
neaggarwMS
previously approved these changes
Aug 13, 2020
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
I think removing the pointer return type from cns/restserver/util.go's validateIpConfigRequest would make things a bit simpler, but otherwise lgtm
neaggarwMS
approved these changes
Aug 14, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* fix: present podinfo to delete * fix: return empty struct instead of pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
IPAM delete in CNS was not passing pod info, therefore ID in state was never found
Issue Fixed:
Requirements:
Notes: