Added more details for podIpInfo in response to CNI GetIpConfigRequest #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
- Coverage 42.10% 41.99% -0.12%
==========================================
Files 71 71
Lines 10270 10266 -4
==========================================
- Hits 4324 4311 -13
- Misses 5471 5477 +6
- Partials 475 478 +3 |
matmerr
approved these changes
Aug 19, 2020
Member
matmerr
left a comment
matmerr
left a comment
There was a problem hiding this comment.
golint shows restserver/ipam.go:21:3: var podIpInfo should be podIPInfo to which I agree, but that can be done in a later PR
neaggarwMS
added a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
Azure#658) * Added more details for podIpInfo in response to CNI GetIpConfigRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more details for podIpInfo in response to CNI GetIpConfigRequest.
Still working on pulling HostIP details