Add list deletion and validation in unit test. #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 42.10% 42.07% -0.03%
==========================================
Files 71 71
Lines 10270 10270
==========================================
- Hits 4324 4321 -3
- Misses 5471 5473 +2
- Partials 475 476 +1 |
matmerr
approved these changes
Aug 19, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: flaky unit test.
Reason for Change:
Ipset deletion unit test was flaky at deletion path. It is caused by ipset which didn't get cleaned up when previous tests end. Add deletion and validation to make sure unit test is not flaky anymore.
test: Testing 💚