Fix flaky ipset unit test #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 42.26% 41.27% -0.99%
==========================================
Files 72 80 +8
Lines 10350 12165 +1815
==========================================
+ Hits 4374 5021 +647
- Misses 5508 6607 +1099
- Partials 468 537 +69 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matmerr
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: flaky ipset unit test.
Reason for Change:
Unit test is flaky since it can be influenced by other ipsets exist in the system. If there are ipsets got referenced from kernel, flush or destroy won't delete it but return error. TestDestroy validation should changed to validate whether the testing ipset got deleted or not.
Issue Fixed:
Flaky unit test.
test: Testing 💚