CNS CRD nullref fix #673
Merged
CNS CRD nullref fix #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 42.63% 41.69% -0.95%
==========================================
Files 72 72
Lines 10392 9483 -909
==========================================
- Hits 4431 3954 -477
+ Misses 5482 5057 -425
+ Partials 479 472 -7 |
matmerr
force-pushed
the
openaicnsinvestigation
branch
from
8379eff to
316006f
Compare
neaggarwMS
reviewed
Sep 18, 2020
cns/restserver/internalapi.go
Outdated
| logger.Errorf("[cns-rc] Error creating or updating IPAM Pool Monitor: %v", err) | ||
| // requeue | ||
| return UnexpectedError | ||
| if scalar != nil && spec != nil { |
Member
There was a problem hiding this comment.
we should not be even calling CreateNC call if scaler/spec are null
| } | ||
|
|
||
| // If there are no NCs, pass nil to CNSClient | ||
| if len(nodeNetConfig.Status.NetworkContainers) == 0 { |
Member
There was a problem hiding this comment.
This should only be called if NodeNetworkConfig is null
pjohnst5
approved these changes
Sep 18, 2020
Contributor
pjohnst5
left a comment
pjohnst5
left a comment
There was a problem hiding this comment.
Looks good to me, talked about this in teams chat, and this is good in case the CRD is defined on the cluster, but the NNC instance of the crd isn't there yet, I missed that
neaggarwMS
approved these changes
Sep 21, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fixes an issue where if the CRD is nil, then don't pass to IPAM pool monitor
Issue Fixed:
Requirements:
Notes: