Add logging to record CNI_COMMAND value #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 41.69% 41.69%
=======================================
Files 72 72
Lines 9483 9483
=======================================
Hits 3954 3954
Misses 5057 5057
Partials 472 472 |
cni/network/plugin/main.go
Outdated
| } | ||
|
|
||
| // Check CNI_COMMAD value for logging purposes. | ||
| cmd := os.Getenv("CNI_COMMAND") |
Contributor
There was a problem hiding this comment.
can we extract to a const?
ramiro-gamarra
approved these changes
Sep 21, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* Add logging to record CNI_COMMAND value * Addressed commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen cases where our CNI is getting called for COMMAND with commands other ADD/DEL.
CHECK is only supported for 0.4.0 and above, and current logging gives an impression CNI DID nothing for ADD/DEL calls.