test: stop skipping windows test #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjohnst5
changed the title
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 42.63% 41.69% -0.95%
==========================================
Files 72 72
Lines 10392 9483 -909
==========================================
- Hits 4431 3954 -477
+ Misses 5482 5057 -425
+ Partials 479 472 -7 |
matmerr
approved these changes
Sep 23, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
A test was being skipped due to our config files listing agent nodes as availability sets instead of vmss's.
Requirements:
This test which makes sure containers come back up correctly after a restart was being skipped because our config files had the agent nodes as availability sets instead of vmss.
https://github.com/Azure/aks-engine/blob/c670571cd42c68ecddca9a9379a5a1d3b0cd6a69/test/e2e/kubernetes/kubernetes_test.go#L2238