Throw CNI error - On CNI DEL call, if communication with CNS cannot be established. #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninzavivek
changed the title
ninzavivek
requested review from
aegal,
ashvindeodhar,
jaer-tsun,
ramiro-gamarra and
tamilmani1989
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 38.63% 38.56% -0.07%
==========================================
Files 78 79 +1
Lines 10430 10446 +16
==========================================
- Hits 4030 4029 -1
- Misses 5909 5925 +16
- Partials 491 492 +1 |
Member
|
Ideally we shouldn't need to go to CNS to get the network name for the endpoint that is already created. Regardless of the CNS state we should be able to delete the endpoint in CNI. |
Member
|
looks good to me but lets wait for the pipeline issue to get resolved so that this gets validated with e2e tests |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramiro-gamarra
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNI is some cases is unable to talk to CNS. This can happen, CNS crashing or race between start/CNI getting invoked.
Currently if this communication errrs out on DEL calls, CNI will silently ignore the error. Container runtime assumes everything went fine and deletes the container. But the HNS endpoints are still there on the host result into them being orphaned. If a container with similar configuration is placed on the host , then ADD call will fail with object already exists error.
Please note, CNI DEL are supposed to be idempotent, and should generally handle the resource not found/exist error elegantely without any error.