Skip to content

Disable vnet ipam for multitenancy #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2020
Merged

Disable vnet ipam for multitenancy #684

merged 1 commit into from
Oct 1, 2020

Conversation

@ninzavivek
Copy link
Contributor

@ninzavivek ninzavivek commented Oct 1, 2020

azure-vnet-ipam should not called for multitenancy path.

tamilmani1989
tamilmani1989 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aegal
aegal approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@aegal aegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ninzavivek ninzavivek merged commit fa9bc99 into Azure:master Oct 1, 2020
@ninzavivek ninzavivek deleted the vivek_ipamdisable branch October 2, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tamilmani1989 tamilmani1989 tamilmani1989 approved these changes

+1 more reviewer

@aegal aegal aegal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ninzavivek @tamilmani1989 @aegal