Call GetNCVersionStatus API to validate the datapath setup #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 38.32% 38.89% +0.57%
==========================================
Files 80 80
Lines 10585 10625 +40
==========================================
+ Hits 4057 4133 +76
+ Misses 6029 5992 -37
- Partials 499 500 +1 |
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
csfmomo
reviewed
Oct 17, 2020
Contributor
|
TestGetNetworkContainerByOrchestratorContext and TestGetInterfaceForNetworkContainer unit test seems have a nil return for api_test, we could re-run those unit test locally to see whether its flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change calls GetNCVersionStatus API for NMAgent to validate if the data path is set up. If the data path is set up, the NC version with CNS matches with the NC version programmed by NMAgent. A conservative approach is taken to check if the data path is set up i.e. only if GetNCVersionStatus successfully returns NC version mismatch, it is treated as error. All the other cases including error in calling this API are considered success.
This is multitenancy only change.
Reason for Change:
Issue Fixed:
Requirements:
Notes: