Add NC version in nnc CRD. Populate NC version info from nnc CRD to N… #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neaggarwMS
previously approved these changes
Oct 7, 2020
| ncRequest.SecondaryIPConfigs = make(map[string]cns.SecondaryIPConfig) | ||
| ncRequest.NetworkContainerid = nc.ID | ||
| ncRequest.NetworkContainerType = cns.Docker | ||
| ncRequest.Version = nc.Version |
Member
There was a problem hiding this comment.
Previous CRD definitions already deployed/running in our test clusters will not have this version field. @ramiro-gamarra or @thatmattlong, Shall we handle the update otherwise we will have to manually delete and re-create the CRD def again whenever we deploy this CNS. I would say lets handle the update
Collaborator
There was a problem hiding this comment.
This is a good use-case for kubernetes api versioning. We should increment the version of this Kind. See https://kubebuilder.io/cronjob-tutorial/gvks.html for a description
| ncRequest.SecondaryIPConfigs = make(map[string]cns.SecondaryIPConfig) | ||
| ncRequest.NetworkContainerid = nc.ID | ||
| ncRequest.NetworkContainerType = cns.Docker | ||
| ncRequest.Version = nc.Version |
Member
There was a problem hiding this comment.
Yes NNC doesnt have Version defined: https://github.com/Azure/azure-container-networking/blob/master/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go
neaggarwMS
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add NC version in nnc CRD and populate it to NC request.
Reason for Change:
It's a prerequisite for IP classification feature. In IP classification feature, CNS will validate IPs through comparing NC version between its local file, nnc CRD and NMAgent to determine whether its available or still pending programming.