Support for ACL (Hnsv2) #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 38.73% 38.89% +0.16%
==========================================
Files 79 80 +1
Lines 10487 10625 +138
==========================================
+ Hits 4062 4133 +71
- Misses 5936 5992 +56
- Partials 489 500 +11 |
ninzavivek
commented
Oct 29, 2020
Contributor
Author
|
@ashvindeodhar / @pjohnst5 - Let me if it is ok to put these in the default conf file [single tenant] or not, I think it is a good idea. |
thatmattlong
reviewed
Nov 3, 2020
ashvindeodhar
requested changes
Nov 3, 2020
Member
|
@ninzavivek are done with docker testing? The comment in the description says - I think it should be ok to add those ACLs by default. I have resolved the review comment. |
ashvindeodhar
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for ACL (Windows - Hnsv2). This is needed so that access to wireserver can be blocked from inside the container.
Also added an ACL rule for blocking the access to wireserver by default.
Testing : Singetenancy - containerd.