changes to support http and https for CNS #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 38.36% 38.78% +0.42%
==========================================
Files 80 83 +3
Lines 10585 10697 +112
==========================================
+ Hits 4061 4149 +88
- Misses 6025 6044 +19
- Partials 499 504 +5 |
ashvindeodhar
requested changes
Nov 3, 2020
Contributor
ramiro-gamarra
left a comment
ramiro-gamarra
left a comment
There was a problem hiding this comment.
Few comments/questions
ramiro-gamarra
previously approved these changes
Nov 4, 2020
ashvindeodhar
previously approved these changes
Nov 5, 2020
ramiro-gamarra
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This introduces HTTPS to Azure CNS
Requirements:
Notes: