log what ips we got and make defer pickup when no ips are found #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgmiller
commented
Nov 4, 2020
thatmattlong
reviewed
Nov 6, 2020
thatmattlong
previously approved these changes
Nov 6, 2020
weng271190436
previously approved these changes
Nov 6, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulgmiller
dismissed stale reviews from weng271190436 and thatmattlong
via
20b557b
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 38.89% 38.80% -0.10%
==========================================
Files 80 83 +3
Lines 10625 10700 +75
==========================================
+ Hits 4133 4152 +19
- Misses 5992 6042 +50
- Partials 500 506 +6 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 720 in repo Azure/azure-container-networking |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matmerr
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We had an incident where it seems like nmagent returned an empty list of ip address.
Improve logging so we know next time
Issue Fixed:
Requirements:
Notes: