Configurable wireserver endpoint #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
- Coverage 39.36% 39.24% -0.12%
==========================================
Files 83 83
Lines 10827 10834 +7
==========================================
- Hits 4262 4252 -10
- Misses 6061 6083 +22
+ Partials 504 499 -5 |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
pushed a commit
to tamilmani1989/azure-container-networking
that referenced
this pull request
Jun 20, 2021
This PR updates the mock nmagent to support returning an NC version. Once we get a release of the ACN repo containing the changes in [this PR](Azure#738), the pipeline checks here should work again. PR URL: https://msazure.visualstudio.com/DefaultCollection/One/_git/Networking-Aquarius/pullrequest/3832404 Related work items: #8941708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR adds a configuration option for wireserver ip, helpful in cases where we are not in a live environment and need to use mocks for nmagent. It also adds a check in the publish container endpoint to possibly extract the wireserver endpoint from the incoming request; given that the rest of the payload contains urls used to communicate to wireserver, it follows that we should try to use that instead of the internal cns configuration.
Issue Fixed:
Requirements:
Notes: